From f6e392e8db22718993cb2dc60864df4fe7e7df33 Mon Sep 17 00:00:00 2001
From: felinae98 <731499577@qq.com>
Date: Sun, 9 Oct 2022 21:25:11 +0800
Subject: [PATCH] add dedup for data migration

---
 src/plugins/nonebot_bison/config/db.py |  9 +++++++
 tests/config/test_data_migration.py    | 34 +++++++++++++++++++++++---
 2 files changed, 39 insertions(+), 4 deletions(-)

diff --git a/src/plugins/nonebot_bison/config/db.py b/src/plugins/nonebot_bison/config/db.py
index 73f7a46..d862672 100644
--- a/src/plugins/nonebot_bison/config/db.py
+++ b/src/plugins/nonebot_bison/config/db.py
@@ -28,11 +28,20 @@ async def data_migrate():
             for user in all_subs:
                 db_user = User(uid=user["user"], type=user["user_type"])
                 user_to_create.append(db_user)
+                user_sub_set = set()
                 for sub in user["subs"]:
                     target = sub["target"]
                     platform_name = sub["target_type"]
                     target_name = sub["target_name"]
                     key = f"{target}-{platform_name}"
+                    if key in user_sub_set:
+                        # a user subscribe a target twice
+                        logger.error(
+                            f"用户 {user['user_type']}-{user['user']} 订阅了 {platform_name}-{target_name} 两次，"
+                            "随机采用了一个订阅"
+                        )
+                        continue
+                    user_sub_set.add(key)
                     if key in platform_target_map.keys():
                         target_obj, ext_user_type, ext_user = platform_target_map[key]
                         if target_obj.target_name != target_name:
diff --git a/tests/config/test_data_migration.py b/tests/config/test_data_migration.py
index 15732d0..2fc9b7a 100644
--- a/tests/config/test_data_migration.py
+++ b/tests/config/test_data_migration.py
@@ -1,9 +1,6 @@
-import pytest
-
-
 async def test_migration(use_legacy_config):
     from nonebot_bison.config.config_legacy import config as config_legacy
-    from nonebot_bison.config.db import data_migrate, upgrade_db
+    from nonebot_bison.config.db import upgrade_db
     from nonebot_bison.config.db_config import config
 
     config_legacy.add_subscribe(
@@ -54,3 +51,32 @@ async def test_migration(use_legacy_config):
     assert user234_config[0].target.target == "weibo_id"
     assert user234_config[0].target.target_name == "weibo_name"
     assert user234_config[0].tags == []
+
+
+async def test_migrate_dup(use_legacy_config):
+    from nonebot_bison.config.config_legacy import config as config_legacy
+    from nonebot_bison.config.db import upgrade_db
+    from nonebot_bison.config.db_config import config
+
+    config_legacy.add_subscribe(
+        user=123,
+        user_type="group",
+        target="weibo_id",
+        target_name="weibo_name",
+        target_type="weibo",
+        cats=[2, 3],
+        tags=[],
+    )
+    config_legacy.add_subscribe(
+        user=123,
+        user_type="group",
+        target="weibo_id",
+        target_name="weibo_name",
+        target_type="weibo",
+        cats=[2, 3],
+        tags=[],
+    )
+    # await data_migrate()
+    await upgrade_db()
+    user123_config = await config.list_subscribe(123, "group")
+    assert len(user123_config) == 1